chore(smoke-tests): try updating the package index first COMPASS-9405 #6955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
no release notes
kraenhansen
force-pushed
the
kh/install-tests/fix-deb-linux
branch
from
0209388 to
ebc053f
Compare
kraenhansen
changed the title
gribnoysup
approved these changes
May 23, 2025
| // Update package index first to avoid fetching missing packages | ||
| execute('sudo', ['apt-get', 'update']); | ||
| // Using "apt" instead of "apt-get" to install dependencies | ||
| execute('sudo', ['apt', 'install', filepath]); |
Collaborator
There was a problem hiding this comment.
I think it's okay for our case, but worth keeping in mind that apt man page specifically doesn't recommend usage in scripts 🙂
Contributor
Author
There was a problem hiding this comment.
Yeah - I was considering using apt-get, but as far as I can tell, that won't install dependencies of the archive.
Collaborator
There was a problem hiding this comment.
That's fine, yeah, you can run multiple commands in sequence to basically do what apt does, but also we can make an argument that we're testing the exact flow our users will go through, so that would make using apt directly more appropriate 🙂
Contributor
Author
kraenhansen
changed the title
kraenhansen
removed
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an attempt at stabalizing the install / smoke tests on Debian.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes